fix: add download attribute to fix JAR files saving as ZIP in Chromium#6065
Merged
Conversation
- JAR files were downloading with a `.zip` extension in Chromium-based browsers (Chrome, Edge, Arc, Brave, Opera, Vivaldi) - Root cause: JAR files are ZIP archives internally, so Chromium sniffs the `Content-Type` as `application/zip` and overrides the filename extension when no `download` attribute is present - Fix: add `download="<filename>"` to all file download `<a>` tags so the browser uses the original filename from the API
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Member
|
looks to have missed a few places, such as the download modal on project pages and the changelog page. versions page changes should also be copied over to /settings/versions |
Missed in initial pass: changelog page button, versions overflow menu, settings/versions overflow menu. Also adds `download` prop to Button and OverflowMenu to support dropdown link items. Adds missing `getPrimaryFile` definition in changelog.vue.
Contributor
Author
|
fix: add download attribute to remaining download links |
Member
|
still missing the buttons in the download modal on project pages |
Contributor
Author
|
VersionSummary.vue was fixed in 67ca4f1, this is my first pr :} and i checked and i dont really understand which exact button is still missing the download attribute? Thank you |
Member
|
oh my bad, version summary is the one. thanks! |
Prospector
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.zipextension in Chromium-based browsers (Chrome, Edge, Arc, Brave, Opera, Vivaldi)Content-Typeasapplication/zipand overrides the filename extension when nodownloadattribute is presentdownload="<filename>"to all file download<a>tags so the browser uses the original filename from the APICloses #6063